Conversation
Contributor
|
I don't suppose we could do something like |
Member
Author
|
That's what I meant with additional work being necessary, but needs some refactoring around asc. For now this just enables experimenting with it. |
This was referenced Sep 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables experimenting with alternative file extensions, by making the default extension overridable in asc, using the (temporary)
--extensionoption. While this works, there are various follow-up issues obviously that need to be addressed eventually, like allowing multiple file extensions to be valid if one imports a foreign module's sources directly that are using.ts, but I guess this can wait until we know more (stdlib is extension agnostic).Related: #1003, https://github.com/AssemblyScript/meta/issues/32